Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] Inline sourcemap #1534

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Experiment] Inline sourcemap #1534

wants to merge 1 commit into from

Conversation

sle-c
Copy link
Contributor

@sle-c sle-c commented Sep 19, 2024

WHY are these changes introduced?

Fixes https://github.com/Shopify/first-party-library-planning/issues/673

WHAT is this pull request doing?

How to test the change?

  • Make sure you clear all rm -rf **/dist/ folder
  • Run pnpm run build to rebuild. Check some dist folders to see if the code contains the sourcemap at the end of the file. It should be pretty long because it contains the source code in there.
  • In your remix app created from the remix template. Update the @shopify/shopify-app-remix package to point to file://your/path/to/this/packages/apps/shopify-app-remix to install the local dependency.
  • Follow the reproduction step in the issue.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant